Re: [PATCH 5/5] build-sys: replace makefiles to wrap meson/ninja

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

On Mon, Dec 07, 2020 at 05:00:55PM +0400, marcandre.lureau@xxxxxxxxxx wrote:
> From: Marc-André Lureau <marcandre.lureau@xxxxxxxxxx>
> This avoids maintaining two build systems, and update the documentation.
> Makefile now wrap meson, so that make all/check/checkm/clean/install
> continue working as they used to.
> Signed-off-by: Marc-André Lureau <marcandre.lureau@xxxxxxxxxx>

Sorry I've neglected this so long.  I finally got around to lookup up
a cheatsheet for how to use meson "natively" to understand this

Couple of issues with this path though:

> ---
>  Makefile                   | 380 ++-----------------------------------
>  Makefile.convert-dtsv0     |  14 --
>  Makefile.dtc               |  23 ---
>  Makefile.utils             |  31 ---
>  README                     |  24 ++-
>  libfdt/Makefile.libfdt     |  18 --
>  pylibfdt/Makefile.pylibfdt |  30 ---
>  tests/Makefile.tests       | 100 ----------

First, it no longer applies clean due to some added tests.  Can you
rebase please.

> +checkm:
> +	WITH_VALGRIND=1 meson test -C $(BUILD_DIR) -v

Second, the valgrind stuff doesn't seem to work.  I tried
"WITH_VALGRIND=1 meson test" and it completes much to fast to actually
be using valgrind.  Also it doesn't give any error if valgrind isn't

It's also not ideal that the output from "meson test" is trivial with
all the content now in the meson log file.  Assuming we can sort out
this first part, would you be willing to help convert the existing
testsuite / testrunner to be more "meson native" so we can improve

David Gibson			| I'll have my music baroque, and my code
david AT	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!

Attachment: signature.asc
Description: PGP signature

[Index of Archives]     [Device Tree]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux