On Thu, Oct 01, 2020 at 05:46:28PM +0100, Andre Przywara wrote: > With -Wsign-compare, compilers warn about a mismatching signedness > in a comparison in fdt_setprop_inplace_namelen_partial(). > > fdt_getprop_namelen() will only return negative error values in "proplen" > if the return value is NULL. So we can rely on "proplen" being positive > in our case and can safely cast it to an unsigned type. > > Signed-off-by: Andre Przywara <andre.przywara@xxxxxxx> Applied, thanks. > --- > libfdt/fdt_wip.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libfdt/fdt_wip.c b/libfdt/fdt_wip.c > index f64139e..c2d7566 100644 > --- a/libfdt/fdt_wip.c > +++ b/libfdt/fdt_wip.c > @@ -23,7 +23,7 @@ int fdt_setprop_inplace_namelen_partial(void *fdt, int nodeoffset, > if (!propval) > return proplen; > > - if (proplen < (len + idx)) > + if ((unsigned)proplen < (len + idx)) > return -FDT_ERR_NOSPACE; > > memcpy((char *)propval + idx, val, len); -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson
Attachment:
signature.asc
Description: PGP signature
