On Thu, Oct 01, 2020 at 05:46:30PM +0100, Andre Przywara wrote:
> With -Wsign-compare, compilers warn about a mismatching signedness
> in a comparison in fdt_strerror().
>
> Force FDT_ERRTABSIZE to be signed (it's surely small enough to fit), so
> that the types match. Also move the minus sign to errval, as this is
> actually what we use in the next line.
>
> Signed-off-by: Andre Przywara <andre.przywara@xxxxxxx>
Applied, thanks.
> ---
> libfdt/fdt_strerror.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/libfdt/fdt_strerror.c b/libfdt/fdt_strerror.c
> index 768db66..b435693 100644
> --- a/libfdt/fdt_strerror.c
> +++ b/libfdt/fdt_strerror.c
> @@ -40,7 +40,7 @@ static struct fdt_errtabent fdt_errtable[] = {
> FDT_ERRTABENT(FDT_ERR_NOPHANDLES),
> FDT_ERRTABENT(FDT_ERR_BADFLAGS),
> };
> -#define FDT_ERRTABSIZE (sizeof(fdt_errtable) / sizeof(fdt_errtable[0]))
> +#define FDT_ERRTABSIZE ((int)(sizeof(fdt_errtable) / sizeof(fdt_errtable[0])))
>
> const char *fdt_strerror(int errval)
> {
> @@ -48,7 +48,7 @@ const char *fdt_strerror(int errval)
> return "<valid offset/length>";
> else if (errval == 0)
> return "<no error>";
> - else if (errval > -FDT_ERRTABSIZE) {
> + else if (-errval < FDT_ERRTABSIZE) {
> const char *s = fdt_errtable[-errval].str;
>
> if (s)
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
Attachment:
signature.asc
Description: PGP signature
