On Mon, Sep 21, 2020 at 05:52:55PM +0100, Andre Przywara wrote:
> From: Simon Glass <sjg@xxxxxxxxxxxx>
>
> With -Wsign-compare, compilers warn about a mismatching signedness in
> comparisons in fdt_get_string().
>
> In the first two cases, we have just established that the signed values
> are not negative, so it's safe to cast the values to an unsigned type.
>
> Signed-off-by: Simon Glass <sjg@xxxxxxxxxxxx>
> Signed-off-by: Andre Przywara <andre.przywara@xxxxxxx>
Applied, thanks.
> ---
> libfdt/fdt_ro.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/libfdt/fdt_ro.c b/libfdt/fdt_ro.c
> index 3c8d143..ddb5a2d 100644
> --- a/libfdt/fdt_ro.c
> +++ b/libfdt/fdt_ro.c
> @@ -53,7 +53,7 @@ const char *fdt_get_string(const void *fdt, int stroffset, int *lenp)
>
> err = -FDT_ERR_BADOFFSET;
> absoffset = stroffset + fdt_off_dt_strings(fdt);
> - if (absoffset >= totalsize)
> + if (absoffset >= (unsigned)totalsize)
> goto fail;
> len = totalsize - absoffset;
>
> @@ -61,7 +61,7 @@ const char *fdt_get_string(const void *fdt, int stroffset, int *lenp)
> if (stroffset < 0)
> goto fail;
> if (can_assume(LATEST) || fdt_version(fdt) >= 17) {
> - if (stroffset >= fdt_size_dt_strings(fdt))
> + if ((unsigned)stroffset >= fdt_size_dt_strings(fdt))
> goto fail;
> if ((fdt_size_dt_strings(fdt) - stroffset) < len)
> len = fdt_size_dt_strings(fdt) - stroffset;
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
Attachment:
signature.asc
Description: PGP signature
