With -Wsign-compare, compilers warn about a mismatching signedness in a comparison in fdt_add_string_(). As struct_top can only be positive, just use an unsigned type for it, and avoid the signedness difference. Signed-off-by: Andre Przywara <andre.przywara@xxxxxxx> --- libfdt/fdt_sw.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libfdt/fdt_sw.c b/libfdt/fdt_sw.c index d10a720..d65e9c8 100644 --- a/libfdt/fdt_sw.c +++ b/libfdt/fdt_sw.c @@ -249,7 +249,8 @@ static int fdt_add_string_(void *fdt, const char *s) char *strtab = (char *)fdt + fdt_totalsize(fdt); int strtabsize = fdt_size_dt_strings(fdt); int len = strlen(s) + 1; - int struct_top, offset; + unsigned int struct_top; + int offset; offset = -strtabsize - len; struct_top = fdt_off_dt_struct(fdt) + fdt_size_dt_struct(fdt); -- 2.17.5
