Re: [PATCH v2] Fix dts output of string lists with dtb and fs input

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]



On Tue, Dec 4, 2018 at 11:11 PM David Gibson
<david@xxxxxxxxxxxxxxxxxxxxx> wrote:
>
> On Wed, Oct 10, 2018 at 09:15:04AM -0500, Rob Herring wrote:
> > Commit 32b9c6130762 ("Preserve datatype markers when emitting dts format")
> > fails to split string lists into multiple strings and instead just outputs
> > a "\0" between strings. This is broken when the input is dtb or fs tree.
>
> Sorry I've take forever to get around to replying to this.

I'd forgotten about it...

> > This could be fixed in the dts output where the problem was introduced,
> > but fix it by adding markers on the input side instead. This will allow
> > for any possible future uses of type markers.
>
> I actually don't like this approach and would prefer to handle it
> purely in the output.  At present the output has two clear cases: a)
> it has TYPE markers and so knows the right way to present things, or
> b) it doesn't, and has to guess.

Ugg, this paragraph should have been removed from v1 because this
version does fix this in the output. You said the same thing on v1.

So any problems with the changes themselves?

Rob



[Index of Archives]     [Device Tree]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux