Re: [PATCH] checks: Fix crash with multiple source annotations

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]



On Wed, Nov 28, 2018 at 12:20:52PM -0600, Rob Herring wrote:
> On Tue, Nov 27, 2018 at 6:31 PM David Gibson
> <david@xxxxxxxxxxxxxxxxxxxxx> wrote:
> >
> > On Tue, Nov 27, 2018 at 08:16:30AM -0600, Rob Herring wrote:
> > > Commit 3616b9a811b6 ("checks: Use source position information for check
> > > failures") causes crashes when there's a check message with multiple
> > > source annotations. Drop the errant addition to the str pointer left
> > > over from the previous version.
> > >
> > > Signed-off-by: Rob Herring <robh@xxxxxxxxxx>
> >
> > Applied.  Although,
> 
> Not pushed out yet it seems.

Should be now.

> 
> > 1) I don't think "errant" means what you think it means (granted, some
> >    IBM doc authors appear to have the same delusion)
> >
> > 2) A test would be nice.
> 
> Yeah, will put that on my list.
> 
> Rob
> 

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Device Tree]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux