[PATCH] checks: Fix crash with multiple source annotations

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]



Commit 3616b9a811b6 ("checks: Use source position information for check
failures") causes crashes when there's a check message with multiple
source annotations. Drop the errant addition to the str pointer left
over from the previous version.

Signed-off-by: Rob Herring <robh@xxxxxxxxxx>
---
 checks.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/checks.c b/checks.c
index 4dfdf485ea87..4834e44b37b2 100644
--- a/checks.c
+++ b/checks.c
@@ -123,7 +123,7 @@ static inline void  PRINTF(5, 6) check_msg(struct check *c, struct dt_info *dti,
 			pos = pos->next;
 
 			file_str = srcpos_string(pos);
-			str += xasprintf_append(&str, "  also defined at %s\n", file_str);
+			xasprintf_append(&str, "  also defined at %s\n", file_str);
 			free(file_str);
 		}
 	}
-- 
2.19.1




[Index of Archives]     [Device Tree]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux