Re: [PATCH 3/9] pylibfdt: Link extension module with libfdt rather than rebuilding

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]



On 10 September 2018 at 06:59, David Gibson <david@xxxxxxxxxxxxxxxxxxxxx> wrote:
> Currently we build the Python extension module from all the libfdt source
> files as well as the swig wrapper file.  This is a bit silly, since we've
> already compiled libfdt itself.
>
> This changes the build to instead build the extension module from just the
> swig wrapper, linking it against the libfdt.a we've already build.
>
> Signed-off-by: David Gibson <david@xxxxxxxxxxxxxxxxxxxxx>
> ---
>  pylibfdt/Makefile.pylibfdt | 14 ++++++--------
>  pylibfdt/setup.py          | 17 ++++++-----------
>  2 files changed, 12 insertions(+), 19 deletions(-)

Good to be able to remove this. I recall adding it to fix errors I got
in an ebuild, but there is no reason why Python has to build this
stuff.

Reviewed-by: Simon Glass <sjg@xxxxxxxxxxxx>



[Index of Archives]     [Device Tree]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux