Re: [PATCH 2/9] pylibfdt: Correctly set build output directory

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]



On 10 September 2018 at 06:59, David Gibson <david@xxxxxxxxxxxxxxxxxxxxx> wrote:
> Our Makefile currently passes PYLIBFDT_objdir into setup.py in an attempt
> to set the correct place to put the Python extension module output.  But
> that gets passed in the 'package_dir' map in distutils.
>
> But that's basically not what package_dir controls.  What actually makes us
> find the module in the right place is the --inplace passed to setup.py
> (causing the module to go into the current directory), and the following
> 'mv' in the Makefile to move it into the right final location.
>
> We can simplify setup.py by dropping the useless objdir stuff, and get the
> module put in the right place straight way by instead using the --build-lib
> setup.py option.
>
> Signed-off-by: David Gibson <david@xxxxxxxxxxxxxxxxxxxxx>
> ---
>  pylibfdt/Makefile.pylibfdt |  6 ++----
>  pylibfdt/setup.py          | 11 +++--------
>  2 files changed, 5 insertions(+), 12 deletions(-)
>

Reviewed-by: Simon Glass <sjg@xxxxxxxxxxxx>



[Index of Archives]     [Device Tree]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux