Re: Changes in DTS output

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]



Rob Herring <robh@xxxxxxxxxx> writes:
> On Thu, Sep 13, 2018 at 11:50 PM Stewart Smith <stewart@xxxxxxxxxxxxx> wrote:
>>
>> Hi!
>>
>> It appears that 32b9c61307629ac76c6ac0bead6f926d579b3d2c has introduced
>> a couple of regressions in the DTS output:
>>
>> For a start, I get
>>     compatible = "ibm,powernv\0ibm,firenze";
>> Rather than
>>     compatible = "ibm,powernv", "ibm,firenze";
>> (which is what I'd expect, and what's in the dts)
>
> I guess this happens when there are no markers. I guess our choices
> are handle this in the output or add markers on input.

I should look into that for what we produce from firmware too.

>> Additionally, the whitespace is different:
>> phandle = <0x44>;
>> versus, now:
>> phandle = < 0x44 >;
>>
>> which breaks diffing the dts, which has proved a rather nice unit test
>> for my device tree producing firmware.
>
> That's a pretty easy fix. Will send a patch soon.

Thanks!

-- 
Stewart Smith
OPAL Architect, IBM.




[Index of Archives]     [Device Tree]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux