Re: [PATCH 3/3 v2] annotations: add the annotation functionality

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]




On Tue, 16 Jan 2018, Frank Rowand wrote:

> On 01/16/18 21:50, Julia Lawall wrote:
> >
> >
> > On Tue, 16 Jan 2018, Frank Rowand wrote:
> >
> >> Hi Julia,
> >>
> >> When I was creating the sample output for this reply to David,
> >> I noticed that the --annotate-full annotation for the dtc
> >> generated content (eg the phandle properties) are reporting
> >> "/* <no-file>:<no-line> */".  Did you intend to remove this,
> >> as you did for the --annotate-full case?
> >
> >>From what you say, it is done backwards.  --annotate-full was intended to
> > say no file no line and --annotate was supposed to put nothing at all.
>
> I think it is working as intended then:
>
>   --annotate-full says: /* <no-file>:<no-line> */
>
>   --annotate says: nothing

Yes, that's the intent.

thanks,
julia

>
> Thanks,
>
> -Frank
>
> >
> > julia
> >
> >> -Frank
> >>
> >>
> >> On 01/16/18 20:13, Frank Rowand wrote:
> >>> On 01/16/18 17:13, David Gibson wrote:
> >>>> On Mon, Jan 15, 2018 at 07:24:10PM +0100, Julia Lawall wrote:
> >>>>> This commit provides two new command-line options:
> >>>>>
> >>>>> --annotate (abbreviated -T)
> >>>>> --annotate-full (abbreviated -F)
> >>>>
> >>>> What's the rationale for having two different versions of the
> >>>> annotations?
> >>>
> >>> I'll put an example to try to explain, at the end of this email.
> >>>
> >>
> >> < snip >
> >>
> >
>
> --
> To unsubscribe from this list: send the line "unsubscribe devicetree-compiler" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>
--
To unsubscribe from this list: send the line "unsubscribe devicetree-compiler" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Device Tree]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux