On Tue, Jan 2, 2018 at 6:03 PM, David Gibson <david@xxxxxxxxxxxxxxxxxxxxx> wrote: > On Tue, Jan 02, 2018 at 03:54:30PM -0600, Kyle Evans wrote: >> Hi, >> >> I'm working on using libfdt's overlay support in bootloaders on >> FreeBSD. I find that our BSD-licensed dtc(1) currently generates a >> /__local_fixups__ node that matches the format (roughly, with some >> slight bugs that I need to address) of /__fixups__; i.e. a bunch of >> properties whose values are "path:name:offset". >> >> I've not found any documentation on what is actually valid here, but I >> do know that libfdt will not accept this. Is this completely invalid >> and our BSD-licensed dtc(1) should write /__local_fixups__ >> differently? > > It's completely invalid and your dtc should write /__local_fixups__ > differently. As well as libfdt, the Linux kernel won't accept > overlays in this format, and there might be other tooling which is > also affected. Thanks for the clarification! I'll take this up with our folks, then. =) >> If not, Is it OK enough that a patch would be welcome to >> support this in libfdt? I like the consistency myself, for what it's >> worth. > > Join the club. I complained about this inconsistency when the overlay > formats were proposed, but wasn't listened to. Now it's deployed > pretty widely, so we're stuck with it. Well, that's less than great, but I guess that's how these things go sometimes. -- To unsubscribe from this list: send the line "unsubscribe devicetree-compiler" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html