Re: __local_fixups__ format

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]



On Tue, Jan 02, 2018 at 03:54:30PM -0600, Kyle Evans wrote:
> Hi,
> 
> I'm working on using libfdt's overlay support in bootloaders on
> FreeBSD. I find that our BSD-licensed dtc(1) currently generates a
> /__local_fixups__ node that matches the format (roughly, with some
> slight bugs that I need to address) of /__fixups__; i.e. a bunch of
> properties whose values are "path:name:offset".
> 
> I've not found any documentation on what is actually valid here, but I
> do know that libfdt will not accept this. Is this completely invalid
> and our BSD-licensed dtc(1) should write /__local_fixups__
> differently?

It's completely invalid and your dtc should write /__local_fixups__
differently.  As well as libfdt, the Linux kernel won't accept
overlays in this format, and there might be other tooling which is
also affected.

> If not, Is it OK enough that a patch would be welcome to
> support this in libfdt? I like the consistency myself, for what it's
> worth.

Join the club.  I complained about this inconsistency when the overlay
formats were proposed, but wasn't listened to.  Now it's deployed
pretty widely, so we're stuck with it.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Device Tree]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux