On Mon, Dec 04, 2017 at 10:22:19AM -0600, Rob Herring wrote:
> On Mon, Dec 4, 2017 at 3:07 AM, Peter Rosin <peda@xxxxxxxxxx> wrote:
> > The property is named "sound-dai", not "sound-dais".
>
> Indeed. Unfortunately, we've been inconsistent.
>
> >
> > Fixes: b3bbac02d5e3 ("checks: add phandle with arg property checks")
> > Signed-off-by: Peter Rosin <peda@xxxxxxxxxx>
>
> Reviewed-by: Rob Herring <robh@xxxxxxxxxx>
Applied, thanks.
>
> > ---
> > checks.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > Hi!
> >
> > I don't know if this needs more work? Maybe #sound-dai-cells is optional?
> > Maybe there's a lot of fall-out in the kernel? Anyway, "sound-dais" is
> > definitely not right...
>
> Some of the bindings treated #*-cells as optional with missing being
> treated as 0. IMO, we should fix all those cases because that's really
> the only way we can generically validate bindings.
>
> > BTW, I reviewed the other properties added by the fixed patch and found
> > no other similar spelling mistake.
>
> Thanks.
>
> Rob
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
Attachment:
signature.asc
Description: PGP signature
