Re: [PATCH] checks: fix sound-dai phandle with arg property check

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]



On Mon, Dec 4, 2017 at 3:07 AM, Peter Rosin <peda@xxxxxxxxxx> wrote:
> The property is named "sound-dai", not "sound-dais".

Indeed. Unfortunately, we've been inconsistent.

>
> Fixes: b3bbac02d5e3 ("checks: add phandle with arg property checks")
> Signed-off-by: Peter Rosin <peda@xxxxxxxxxx>

Reviewed-by: Rob Herring <robh@xxxxxxxxxx>

> ---
>  checks.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> Hi!
>
> I don't know if this needs more work? Maybe #sound-dai-cells is optional?
> Maybe there's a lot of fall-out in the kernel? Anyway, "sound-dais" is
> definitely not right...

Some of the bindings treated #*-cells as optional with missing being
treated as 0. IMO, we should fix all those cases because that's really
the only way we can generically validate bindings.

> BTW, I reviewed the other properties added by the fixed patch and found
> no other similar spelling mistake.

Thanks.

Rob
--
To unsubscribe from this list: send the line "unsubscribe devicetree-compiler" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Device Tree]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]

  Powered by Linux