Adding Labels Section to Perf Counters Output

[Ali Maredia <amaredia@xxxxxxxxxx>]

Hi Ceph Developers and Users,

Various upstream developers and I are working on adding labels to perf counters (https://github.com/ceph/ceph/pull/48657).

We would like to understand the ramifications of changing the format of the json dumped by the `perf dump` command for the Reef Release on users and components of Ceph.

As an example given in the PR, currently unlabeled counters are dumped like this in comparison with their new labeled counterparts.

    "some unlabeled_counter": {
        "put_b": 1048576,
    },
    "some labeled_counter": {
        "labels": {
            "Bucket: "bkt1",
            "User: "user1",
        },
        "counters": {
            "put_b": 1048576,
        },
    },

Here is an example given in the PR of the old style unlabeled counters being dumped in the same format as the labeled counters:

    "some unlabeled": {
        "labels": {
        },
        "counters": {
            "put_b": 1048576,
        },
    },
    "some labeled": {
        "labels": {
            "Bucket: "bkt1",
            "User: "user1",
        },
        "counters": {
            "put_b": 1048576,
        },
    },

Would users/consumers of these counters be opposed to changing the format? Why is this the case?

As far as I know there are ceph-mgr modules related to Prometheus and telemetry that are consuming the current unlabeled counters. Also this topic will be discussed at the upcoming Ceph Developer Monthly EMEA as well.

Best,

Ali

_______________________________________________
Dev mailing list -- dev@xxxxxxx
To unsubscribe send an email to dev-leave@xxxxxxx