On Sat, Mar 5, 2022 at 6:00 AM kefu chai <tchaikov@xxxxxxxxx> wrote:
>
> On Fri, Mar 4, 2022 at 1:16 AM Casey Bodley <cbodley@xxxxxxxxxx> wrote:
> >
> > it looks like i've caused some inadvertent breakage to jenkins builds
> > of octopus and pacific backport PRs, due to my c++20 testing in
> > https://github.com/ceph/ceph/pull/45133 which enables the ubuntu PPA
> > and sets gcc11 as default. this default is carrying over to the
> > jenkins builds of other branches, which i did not intend
> >
> > the newer gcc complains about -Werror=misleading-indentation in some
> > macros from the spdk submodule. quincy/master have an updated spdk
> > submodule that has resolved these issues. might we consider pulling it
> > up for octopus and pacific as well?
> >
> > octopus example: https://github.com/ceph/ceph/pull/45206
> > pacific example: https://github.com/ceph/ceph/pull/45245
>
> to bump up spdk *might* involve more backports. i think a better and
> future-proof
> fix would be just prevent dpdk from adding -Werror to its CFLAGS. i am proposing
> https://github.com/ceph/ceph/pull/45258 to address this.
Agreed -- dropping -Werror is both more reliable and backportable.
Casey, might recent Windows build failures in Jenkins (e.g. [1]) be
another casualty?
> g++ --version
g++ (Ubuntu 11.1.0-1ubuntu1~20.04) 11.1.0
FAILED: bin/unittest_str_map.exe
/usr/bin/x86_64-w64-mingw32-ld: lib/libjson_spirit.a(json_spirit_reader.cpp.obj): in function `json_spirit::Semantic_actions<json_spirit::Value_impl<json_spirit::Config_vector<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > >, __gnu_cxx::__normal_iterator<char const*, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > >::end_array(char)':
/home/jenkins-build/build/workspace/ceph-windows-pull-requests/ceph/build/../src/json_spirit/json_spirit_reader_template.h:252: undefined reference to `ceph::__ceph_assert_fail(ceph::assert_data const&)'
[1] https://jenkins.ceph.com/job/ceph-windows-pull-requests/4556/
Thanks,
Ilya
>
> On Fri, Mar 4, 2022 at 1:16 AM Casey Bodley <cbodley@xxxxxxxxxx> wrote:
> >
> > it looks like i've caused some inadvertent breakage to jenkins builds
> > of octopus and pacific backport PRs, due to my c++20 testing in
> > https://github.com/ceph/ceph/pull/45133 which enables the ubuntu PPA
> > and sets gcc11 as default. this default is carrying over to the
> > jenkins builds of other branches, which i did not intend
> >
> > the newer gcc complains about -Werror=misleading-indentation in some
> > macros from the spdk submodule. quincy/master have an updated spdk
> > submodule that has resolved these issues. might we consider pulling it
> > up for octopus and pacific as well?
> >
> > octopus example: https://github.com/ceph/ceph/pull/45206
> > pacific example: https://github.com/ceph/ceph/pull/45245
>
> to bump up spdk *might* involve more backports. i think a better and
> future-proof
> fix would be just prevent dpdk from adding -Werror to its CFLAGS. i am proposing
> https://github.com/ceph/ceph/pull/45258 to address this.
Agreed -- dropping -Werror is both more reliable and backportable.
Casey, might recent Windows build failures in Jenkins (e.g. [1]) be
another casualty?
> g++ --version
g++ (Ubuntu 11.1.0-1ubuntu1~20.04) 11.1.0
FAILED: bin/unittest_str_map.exe
/usr/bin/x86_64-w64-mingw32-ld: lib/libjson_spirit.a(json_spirit_reader.cpp.obj): in function `json_spirit::Semantic_actions<json_spirit::Value_impl<json_spirit::Config_vector<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > >, __gnu_cxx::__normal_iterator<char const*, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > >::end_array(char)':
/home/jenkins-build/build/workspace/ceph-windows-pull-requests/ceph/build/../src/json_spirit/json_spirit_reader_template.h:252: undefined reference to `ceph::__ceph_assert_fail(ceph::assert_data const&)'
[1] https://jenkins.ceph.com/job/ceph-windows-pull-requests/4556/
Thanks,
Ilya
_______________________________________________ Dev mailing list -- dev@xxxxxxx To unsubscribe send an email to dev-leave@xxxxxxx
