it looks like i've caused some inadvertent breakage to jenkins builds of octopus and pacific backport PRs, due to my c++20 testing in https://github.com/ceph/ceph/pull/45133 which enables the ubuntu PPA and sets gcc11 as default. this default is carrying over to the jenkins builds of other branches, which i did not intend the newer gcc complains about -Werror=misleading-indentation in some macros from the spdk submodule. quincy/master have an updated spdk submodule that has resolved these issues. might we consider pulling it up for octopus and pacific as well? octopus example: https://github.com/ceph/ceph/pull/45206 pacific example: https://github.com/ceph/ceph/pull/45245 In file included from src/spdk/dpdk/buildtools/pmdinfogen/pmdinfogen.c:17: src/spdk/dpdk/buildtools/pmdinfogen/pmdinfogen.c: In function 'parse_elf': src/spdk/dpdk/buildtools/pmdinfogen/pmdinfogen.h:78:1: error: this 'else' clause does not guard... [-Werror=misleading-indentation] 78 | else \ | ^~~~ src/spdk/dpdk/buildtools/pmdinfogen/pmdinfogen.h:83:35: note: in expansion of macro 'CONVERT_NATIVE' 83 | #define TO_NATIVE(fend, width, x) CONVERT_NATIVE(fend, width, x) | ^~~~~~~~~~~~~~ src/spdk/dpdk/buildtools/pmdinfogen/pmdinfogen.c:152:28: note: in expansion of macro 'TO_NATIVE' 152 | hdr->e_type = TO_NATIVE(endian, 16, hdr->e_type); | ^~~~~~~~~ src/spdk/dpdk/buildtools/pmdinfogen/pmdinfogen.h:80:9: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'else' 80 | ___x; \ | ^~~~ src/spdk/dpdk/buildtools/pmdinfogen/pmdinfogen.h:83:35: note: in expansion of macro 'CONVERT_NATIVE' 83 | #define TO_NATIVE(fend, width, x) CONVERT_NATIVE(fend, width, x) | ^~~~~~~~~~~~~~ src/spdk/dpdk/buildtools/pmdinfogen/pmdinfogen.c:152:28: note: in expansion of macro 'TO_NATIVE' 152 | hdr->e_type = TO_NATIVE(endian, 16, hdr->e_type); | ^~~~~~~~~ _______________________________________________ Dev mailing list -- dev@xxxxxxx To unsubscribe send an email to dev-leave@xxxxxxx
