Re: Adding -latomic to cmake

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 12/9/21 6:23 PM, kefu chai wrote:
> On Wed, Nov 24, 2021 at 4:56 PM Thomas Goirand <zigo@xxxxxxxxxx> wrote:
>>
>> Hi Kefu,
>>
>> Thanks a lot for your help, that's invaluable!
>>
>> I've applied the mips 16-byte atomic support patch and I will rebuild
>> and re-upload to Experimental, let's see how it goes now! :)
> 
> hi Zigo, i found following error in
> https://buildd.debian.org/status/fetch.php?pkg=ceph&arch=mipsel&ver=16.2.6%2Bds-5&stamp=1639003196&raw=0
> 
> ===== 8< =======
> Run Build Command(s):/usr/bin/gmake -f Makefile cmTC_9f34f/fast &&
> gmake[2]: Entering directory
> '/<<PKGBUILDDIR>>/obj-mipsel-linux-gnu/CMakeFiles/CMakeTmp'
> /usr/bin/gmake  -f CMakeFiles/cmTC_9f34f.dir/build.make
> CMakeFiles/cmTC_9f34f.dir/build
> gmake[3]: Entering directory
> '/<<PKGBUILDDIR>>/obj-mipsel-linux-gnu/CMakeFiles/CMakeTmp'
> Building CXX object CMakeFiles/cmTC_9f34f.dir/src.cxx.o
> /usr/bin/c++ -DHAVE_CXX11_ATOMIC  -g -O2
> -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat
> -Werror=format-security -g1 -Wdate-time -D_FORTIFY_SOURCE=2
> -std=c++11 -fPIE -o CMakeFiles/cmTC_9f34f.dir/src.cxx.o -c
> /<<PKGBUILDDIR>>/obj-mipsel-linux-gnu/CMakeFiles/CMakeTmp/src.cxx
> /<<PKGBUILDDIR>>/obj-mipsel-linux-gnu/CMakeFiles/CMakeTmp/src.cxx:15:44:
> error: template argument 1 is invalid
>    15 | bool atomic16(std::atomic<unsigned __int128> *ptr)
>       |                                            ^
> /<<PKGBUILDDIR>>/obj-mipsel-linux-gnu/CMakeFiles/CMakeTmp/src.cxx:15:44:
> error: template argument 1 is invalid
> /<<PKGBUILDDIR>>/obj-mipsel-linux-gnu/CMakeFiles/CMakeTmp/src.cxx:15:44:
> error: template argument 1 is invalid
> /<<PKGBUILDDIR>>/obj-mipsel-linux-gnu/CMakeFiles/CMakeTmp/src.cxx:15:44:
> error: template argument 1 is invalid
> /<<PKGBUILDDIR>>/obj-mipsel-linux-gnu/CMakeFiles/CMakeTmp/src.cxx:15:47:
> error: ‘ptr’ was not declared in this scope
>    15 | bool atomic16(std::atomic<unsigned __int128> *ptr)
>       |                                               ^~~
> ===== >8 =======
> 
> so it seems that https://github.com/ceph/ceph/pull/44071 does not
> work. could you please help test
> https://github.com/ceph/ceph/pull/44264 ?

Hi,

IMO, that's not what should be done. I've done this:
#if defined(__s390x__) || (defined(__mips__) && _MIPS_SIM ==_ABI64 )

which seems to work as expected: I've done the beginning of the build on
a Debian mipsel porter box, and it built.

I've rebuilt Ceph 16.2.6+ds-6 and uploaded once more to Debian
Experimental, let's see how it goes. If it builds on the remaining arch
(ie: mipsel), then I'll send a PR doing what's above.

Cheers,

Thomas Goirand (zigo)
_______________________________________________
Dev mailing list -- dev@xxxxxxx
To unsubscribe send an email to dev-leave@xxxxxxx




[Index of Archives]     [CEPH Users]     [Ceph Devel]     [Ceph Large]     [Information on CEPH]     [Linux BTRFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux