On Wed, Oct 9, 2019 at 10:56 AM Sage Weil <sweil@xxxxxxxxxx> wrote: > > On Wed, 9 Oct 2019, kefu chai wrote: > > hi folks, > > > > tl;dr: it's a notice/RFC that `do_cmake.sh` won't pass do Debug build > > anymore after https://github.com/ceph/ceph/pull/30250 gets merged. > > I like(d) that the default do_make.sh incantation does a debug build, > which has lockdep enabled, which means that most development and basic > vstart testing happens with lockdep enabled. > > If it's not too much complexity, IMO it would be nice if do_cmake sitll > defaulted to a debug build (but was maybe clever enough to still let you > do a release build for the perf tests)...? thanks the inputs, Sage. will try to get Brad's change merged first, so do_cmake.sh will default to Debug build even with my change. On Wed, Oct 9, 2019 at 9:56 AM Brad Hubbard <bhubbard@xxxxxxxxxx> wrote: > > Would https://github.com/ceph/ceph/pull/30799 be a good idea then or > does having a default of 'RelWithDebInfo' still make sense? thank you, Brad! this change looks great! > > sage > > > > > > long story: i am refactoring do_cmake.sh so we can build Release build > > by passing '-DCMAKE_BUILD_TYPE=Release' to it. so i can leverage the > > existing scripts for running performance test. the reason why i'd > > prefer change the existing behavior is that i want to keep do_cmake.sh > > simpler and straightforward, if we want to keep > > "-DCMAKE_BUILD_TYPE=Debug" as the default behavior, we would need to > > either introduce another command line argument or parse and for this > > parameter passed in. > > > > instead, run-make-check.sh will pass -DCMAKE_BUILD_TYPE=Debug to > > cmake, so if you are using this script to build your tree or run "make > > check", you are not impacted. > > > > please let me know if you have any concerns. otherwise, i will update > > this script by the end of the week (Oct 12). > > > > cheers, > > > > -- > > Regards > > Kefu Chai > > _______________________________________________ > > Dev mailing list -- dev@xxxxxxx > > To unsubscribe send an email to dev-leave@xxxxxxx > > > > -- Regards Kefu Chai _______________________________________________ Dev mailing list -- dev@xxxxxxx To unsubscribe send an email to dev-leave@xxxxxxx
