Would https://github.com/ceph/ceph/pull/30799 be a good idea then or does having a default of 'RelWithDebInfo' still make sense? On Wed, Oct 9, 2019 at 11:12 AM kefu chai <tchaikov@xxxxxxxxx> wrote: > > hi folks, > > tl;dr: it's a notice/RFC that `do_cmake.sh` won't pass do Debug build > anymore after https://github.com/ceph/ceph/pull/30250 gets merged. > > long story: i am refactoring do_cmake.sh so we can build Release build > by passing '-DCMAKE_BUILD_TYPE=Release' to it. so i can leverage the > existing scripts for running performance test. the reason why i'd > prefer change the existing behavior is that i want to keep do_cmake.sh > simpler and straightforward, if we want to keep > "-DCMAKE_BUILD_TYPE=Debug" as the default behavior, we would need to > either introduce another command line argument or parse and for this > parameter passed in. > > instead, run-make-check.sh will pass -DCMAKE_BUILD_TYPE=Debug to > cmake, so if you are using this script to build your tree or run "make > check", you are not impacted. > > please let me know if you have any concerns. otherwise, i will update > this script by the end of the week (Oct 12). > > cheers, > > -- > Regards > Kefu Chai > _______________________________________________ > Dev mailing list -- dev@xxxxxxx > To unsubscribe send an email to dev-leave@xxxxxxx -- Cheers, Brad _______________________________________________ Dev mailing list -- dev@xxxxxxx To unsubscribe send an email to dev-leave@xxxxxxx
