Re: [Patch 1/1] dccp: CCID2 increment cwnd correctly

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> | My fix is simply to change that test for tx_packets_acked greater than
> | or equal to two in slow start.
> | 
> Excellent catch, thank you very much. This has also been added to the test tree.
> 
> Would you be ok with me reusing the commit message as a comment - or if you
> like, you can also send an update.

I don't think that a comment is really needed here. I don't see that
anyone looking at this code at some point in the future would say "why
did they use >= there?" Particularly, since the test (in congestion
avoidance state) four lines later also uses >= without explanation.

I would consider using >= in this situation (testing for a value of an
incrementing variable) to be good coding practice even if it wasn't
strictly necessary.

Samuel Jero
Internetworking Research Group
Ohio University

Attachment: signature.asc
Description: This is a digitally signed message part


[Index of Archives]     [Linux Kernel]     [IETF DCCP]     [Linux Networking]     [Git]     [Security]     [Linux Assembly]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]

  Powered by Linux