| > + list_for_each_entry(entry, fn_list, node) | > + if (entry->feat_num == feat_num && entry->is_local == is_local) | > + return entry; | > + else if (entry->feat_num > feat_num) | > + break; | | Personally, I would have put braces around this basic block. | If it is possible to modify without disturbance, I attach a patch for this and have changed it in the test tree. I have checked that making this change does not affect subsequent patches - it works with either variant.
--- a/net/dccp/feat.c +++ b/net/dccp/feat.c @@ -171,11 +171,12 @@ static struct dccp_feat_entry *dccp_feat { struct dccp_feat_entry *entry; - list_for_each_entry(entry, fn_list, node) + list_for_each_entry(entry, fn_list, node) { if (entry->feat_num == feat_num && entry->is_local == is_local) return entry; else if (entry->feat_num > feat_num) break; + } return NULL; }