| > We are always allocating (in dccp_init_sock and dccp_create_openreq_child), | > so why not make dp->dccps_qpolicy a static member rather than a pointer. | > | Then should I keep | void dccp_qpolicy_destroy(struct sock *sk) | as an empty function or delete it? Later it might be used to call policy | specific destructor, but now it wouldn't look very useful... | -- That is a good point. With regard to dccp_qpolicy_init(), the only part that remains after taking the memory allocation out is the assignment of the default policy. I think it would be clearer to replace the call (in dccp_init_sock()) of dccp_qpolicy_init(sk); with dccp_qpolicy_set_id(sk, DCCP_QPOLICY_DEFAULT); Then it is clear how the initialisation is done. The University of Aberdeen is a charity registered in Scotland, No SC013683. -- To unsubscribe from this list: send the line "unsubscribe dccp" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
