Quoting Ian McDonald: | > @@ -124,4 +124,5 @@ extern void dccp_encode_value_var(const | > extern u64 dccp_decode_value_var(const u8 *bf, const u8 len); | > | > extern int dccp_insert_option_mandatory(struct sk_buff *skb); | > +extern int dccp_insert_fn_opt(struct sk_buff *skb, u8, u8, u8 *, u8, bool); | | declarations in kernel should always have parameter names. I personally disagree since I would look at the function itself to tell me what it does (the above had carefully been butchered to match the other constraint of 80 linechars). But I have changed it to the following (I omit the entire patch, the whole lot will be put in the test tree when the discussion phase is over); the inter-diff is: --- a/net/dccp/feat.h +++ b/net/dccp/feat.h @@ -124,5 +124,6 @@ extern void dccp_encode_value_var(const extern u64 dccp_decode_value_var(const u8 *bf, const u8 len); extern int dccp_insert_option_mandatory(struct sk_buff *skb); -extern int dccp_insert_fn_opt(struct sk_buff *skb, u8, u8, u8 *, u8, bool); +extern int dccp_insert_fn_opt(struct sk_buff *skb, u8 type, u8 feat, + u8 *val, u8 len, bool repeat_first); #endif /* _DCCP_FEAT_H */ - To unsubscribe from this list: send the line "unsubscribe dccp" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
