On 10/2/07, Gerrit Renker <gerrit@xxxxxxxxxxxxxx> wrote: > [DCCP]: Update insertion routine for feature-negotiation options > > The patch extends existing code: > * Confirm options divide into the confirmed value plus an optional preference > list for SP values. Previously only the preference list was echoed for SP values, > now the confirmed value is added as per RFC 4340, 6.1; > * length and sanity checks are added to avoid illegal memory (or NULL) access; > * clarified the use of TLV length constant, which does not have anything to do with ECN, but > with the fact that Type-Length-Value options whose length is determined by an u8 > field provide Value space for at most 255 - 2 = 253 bytes due to the Type/Length fields. > > Signed-off-by: Gerrit Renker <gerrit@xxxxxxxxxxxxxx> Acked-by: Ian McDonald <ian.mcdonald@xxxxxxxxxxx> (once one change is put in) > --- > net/dccp/ackvec.c | 8 ++++---- > net/dccp/ackvec.h | 6 +++--- > net/dccp/feat.h | 1 + > net/dccp/options.c | 39 +++++++++++++++++++++++++++++++-------- > 4 files changed, 39 insertions(+), 15 deletions(-) > > --- a/net/dccp/feat.h > +++ b/net/dccp/feat.h > @@ -124,4 +124,5 @@ extern void dccp_encode_value_var(const > extern u64 dccp_decode_value_var(const u8 *bf, const u8 len); > > extern int dccp_insert_option_mandatory(struct sk_buff *skb); > +extern int dccp_insert_fn_opt(struct sk_buff *skb, u8, u8, u8 *, u8, bool); declarations in kernel should always have parameter names. - To unsubscribe from this list: send the line "unsubscribe dccp" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
