Re: [PATCH 3/6] DCCP: Introduce CCID3 extensions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 8/30/07, Gerrit Renker <gerrit@xxxxxxxxxxxxxx> wrote:
> A style comment - I like the idea of the extensions and can see your point.
> To be true, if the code were analysed for extensions then the rfc344bis-00
> extensions would probably also count, as well as the erratum for the SYN
> RTT sample.

Yes, that was the intention - to pick up other uses over time as appropriate.
>
> When using a one-bit flag (which automatically behaves like a Boolean type),
> such as
>         /* @ccid3hctx_faster_restart_on: whether Faster Restart is enabled */
>         /* ... */
>         u8                              ccid3hctx_faster_restart_on:1;
>
> the testing and setting code would be smaller - if a little less elegant.

Understand what you're saying. When/if it gets merged I'll see what
code style Arnaldo wants and go with whichever style he prefers. I
don't mind which one is used.

Ian
-- 
Web1: http://wand.net.nz/~iam4/
Web2: http://www.jandi.co.nz
Blog: http://iansblog.jandi.co.nz
-
To unsubscribe from this list: send the line "unsubscribe dccp" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel]     [IETF DCCP]     [Linux Networking]     [Git]     [Security]     [Linux Assembly]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]

  Powered by Linux