Re: [PATCH 4/5]: Rate-limit DCCP-Syncs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



|  > The default value is set at compilation time when HZ is known. I used jiffies for the
|  > main reason to make this sysctl consistent with the other, similar, runtime variables
|  > which are also in units of jiffies (cf. Documentation/networking/ip-sysctl.txt):
|  > 
|  >  * inet_peer_minttl / inet_peer_maxttl / inet_peer_gc_mintime / inet_peer_gc_maxtime
|  
|  Actually these are in seconds, they use proc_dointvec_jiffies, which
|  takes seconds and converts to jiffies.
I haven't looked at the code - it may be that the information in ip-sysctl.txt is outdated.
  
<snip>
|  I agree with Ian that userspace interfaces should use fixed units that
|  don't depend on compile-time options.
|  
Ok,  will convert patch & Documentation to use milliseconds, and send an update later.

Thank you for the input.
-
To unsubscribe from this list: send the line "unsubscribe dccp" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel]     [IETF DCCP]     [Linux Networking]     [Git]     [Security]     [Linux Assembly]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]

  Powered by Linux