Re: [PATCH 4/5]: Rate-limit DCCP-Syncs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Quoting Ian McDonald:
|  > +sync_ratelimit = HZ/8
|  > +       The timeout between subsequent DCCP-Sync packets sent in response to
|  > +       sequence-invalid packets on the same socket (RFC 4340, 7.5.4). The unit
|  > +       of this parameter is jiffies; a value of 0 disables rate-limiting.
|  > +
|  
|  No, no, no. A userspace parameter in jiffies is just wrong I think.
|  You change HZ and this doesn't automatically change. You could be
|  doing this with different kernels on your machine even and setting
|  sysctls in a file. Take a bit of time and put this in milliseconds.
The default value is set at compilation time when HZ is known. I used jiffies for the
main reason to make this sysctl consistent with the other, similar, runtime variables
which are also in units of jiffies (cf. Documentation/networking/ip-sysctl.txt):

 * inet_peer_minttl / inet_peer_maxttl / inet_peer_gc_mintime / inet_peer_gc_maxtime

 * icmp_ratelimit - which is semantically the closest to this sysctl

Would you still rather have this in milliseconds?
-
To unsubscribe from this list: send the line "unsubscribe dccp" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel]     [IETF DCCP]     [Linux Networking]     [Git]     [Security]     [Linux Assembly]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]

  Powered by Linux