Re: [PATCH 1/1] DCCP: Reorganise loss interval code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Quoting Ian McDonald:
|  >  ==> However, I am not sure that the way  ccid3_hc_rx_update_li() is called is as
|  >      intentioned.
|  >
|  Not sure what you mean here. Can you explain?
The parameters of ccid3_hc_rx_update_li() are:

ccid3_hc_rx_update_li(struct sock *sk, u64 seq_loss, u8 win_loss)
{
	// ... 
	// The following is executed if hcrx->ccid3hcrx_li_hist is non-empty:

	/* calculate last interval length */
	seq_temp = dccp_delta_seqno(head->dccplih_seqno, seq_loss)

	/* Create the newest interval */
	entry->dccplih_seqno = seq_loss;
	entry->dccplih_interval = seq_temp;
	entry->dccplih_win_count = win_loss;
}

>From this it appears that seq_loss / win_loss are associated with _loss_.
However, in ccid3_hc_rx_detect_loss they are called as:


	ccid3_hc_rx_update_li(sk, hcrx->ccid3hcrx_seqno_nonloss,
		   hcrx->ccid3hcrx_ccval_nonloss)

which refers to the _nonloss_ variants. Loss or non_loss?
-
To unsubscribe from this list: send the line "unsubscribe dccp" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel]     [IETF DCCP]     [Linux Networking]     [Git]     [Security]     [Linux Assembly]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]

  Powered by Linux