Re: [PATCH 1/1] DCCP: Reorganise loss interval code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



|  Applies on top of my previous patches. (So I have to convince Gerrit of the
|  merits of them first!)
I tried to apply it but it bombed out with 3 hunks failing. I like the basic idea
and have another suggestion:
 ==>  dccp_li_update_li() is only called in ccid3_hc_rx_detect_loss() and there
      it is called with the arguments
      ccid3_hc_rx_update_li(sk, hcrx->ccid3hcrx_seqno_nonloss,
	      	                hcrx->ccid3hcrx_ccval_nonloss) 

 ==> Since hcrx derives from sk via pointer-cast, and since the last two arguments
     are fields of hcrx, we could simplify the interface to
     ccid3_hc_rx_update_li(sk)

 ==> However, I am not sure that the way  ccid3_hc_rx_update_li() is called is as 
     intentioned.

But for the basic idea,
Signed-off-by: Ian McDonald <ian.mcdonald@xxxxxxxxxxx>
Acked-by: Gerrit Renker <gerrit@xxxxxxxxxxxxxx>
-
To unsubscribe from this list: send the line "unsubscribe dccp" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel]     [IETF DCCP]     [Linux Networking]     [Git]     [Security]     [Linux Assembly]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]

  Powered by Linux