On 11/28/06, Gerrit Renker <gerrit@xxxxxxxxxxxxxx> wrote:
| On 11/29/06, Gerrit Renker <gerrit@xxxxxxxxxxxxxx> wrote: | > Quoting Ian McDonald: | > | I think I didn't explain my point well here. You can't change to u32 | > | but need to be unsigned int (not u64). | > Don't get this: u32 is a 32-bit unsigned value and therefore looks sufficient - and you | > are proposing `unsigned int' to have easier conversion to skb->len, right? | > | OK. On 64 bit platform unsigned int = 64 bits and we are passing a 64 | bit argument (skb->len) into a 32 bit parameter. We either need to | explicitly typecast or change wherever you have put u32 to unsigned | int. | | Arnaldo probably knows which way is better from his experience. My suggestion then is a) remove third arg of send_packet(), use skb->len directly b) implement `unsigned int' as third parameter of packet_sent() ==> Arnaldo what do you think?
Checking... Agreed, send the patch please - Arnaldo - To unsubscribe from this list: send the line "unsubscribe dccp" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
