On 11/29/06, Gerrit Renker <gerrit@xxxxxxxxxxxxxx> wrote:
Quoting Ian McDonald: | I think I didn't explain my point well here. You can't change to u32 | but need to be unsigned int (not u64). Don't get this: u32 is a 32-bit unsigned value and therefore looks sufficient - and you are proposing `unsigned int' to have easier conversion to skb->len, right?
OK. On 64 bit platform unsigned int = 64 bits and we are passing a 64 bit argument (skb->len) into a 32 bit parameter. We either need to explicitly typecast or change wherever you have put u32 to unsigned int. Arnaldo probably knows which way is better from his experience.
No that is not what I meant. Of course this needs to be done with regard to proper conversion - in particular, X_recv. I am at the moment trying to write this up (time consuming task), but the gist of it is - we could eliminate some problems, such as (i) having to multiply by 1E12 when computing X_calc, (ii) get better results when performing direct division. As said, will send further information.
OK. Will have a look at it when it arrives.
Would really appreciate if you could at some time have a look at the moving-average patch. Have communicated with Eddie again about it, and using MSS would at the moment be much more complicated.
Will look at it tomorrow (along with performance testing existing changes in tree) as meant to be preparing coursework and working on PhD today.... Agree MSS is problematic at present without PMTU. My thoughts were to have moving average and explicit s setting as two options available to user. If they don't set s then use moving average. I agree with Eddie that users should be able to define s if they want to. Ian -- Ian McDonald Web: http://wand.net.nz/~iam4 Blog: http://imcdnzl.blogspot.com WAND Network Research Group Department of Computer Science University of Waikato New Zealand - To unsubscribe from this list: send the line "unsubscribe dccp" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
