On 10/02/2023 02:43, Herbert Xu wrote:
On Thu, Feb 09, 2023 at 02:11:54PM +0100, наб wrote:
STATIC int
-describe_command(out, command, path, verbose)
- struct output *out;
- char *command;
- const char *path;
- int verbose;
+describe_command(struct output *out, char *command,
+ const char *path, int verbose)
This looks exactly the same as the first patch. Did you send
out the wrong one perhaps?
It is not the same as the first patch.
Just to recap if we're touching the function definition they
should now look like:
static int describe_command(struct output *out, char *command,
const char *path, int verbose)
Thanks,
It looks like наб took this as a request to break the parameters over
multiple lines, and updated the patch accordingly. The initial patch had
them all on a single line. This is also how I had read the request. It
is only in this second message that I notice that you no longer have a
line break before the function name, so to hopefully help avoid
misunderstandings, I am spelling this out explicitly here.
Cheers,
Harald van Dijk
