On Thu, Feb 09, 2023 at 02:11:54PM +0100, наб wrote: > > STATIC int > -describe_command(out, command, path, verbose) > - struct output *out; > - char *command; > - const char *path; > - int verbose; > +describe_command(struct output *out, char *command, > + const char *path, int verbose) This looks exactly the same as the first patch. Did you send out the wrong one perhaps? Just to recap if we're touching the function definition they should now look like: static int describe_command(struct output *out, char *command, const char *path, int verbose) Thanks, -- Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt