Re: [PATCH] Set LC_ALL instead LC_COLLATE in mkbuiltins

[Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>]

On Thu, May 21, 2015 at 10:40:19PM -0600, Eric Blake wrote:
>
> Why do you care whether any errors printed by sort are in the "C" locale
> (in English) rather than localized?  Ideally, there won't be any sort
> errors in the first place, because this tool is run on controlled input
> as part of the build process.

Your /tmp could be full or sort could be out of memory.

> Setting LC_ALL has the nice property that LC_COLLATE and LC_CTYPE are
> guaranteed to be compatible; if you just set LC_COLLATE but leave
> LC_CTYPE unchanged and unset LC_ALL, it is possible to attempt a
> collation that assumes one character set while still living in a ctype
> that assumes another, and get garbled results.

Show me an actual pair of values for these two that produce
incorrect results for mkbuiltins and I'll happily change both.

Cheers,
-- 
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe dash" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html