Re: [PATCH] Set LC_ALL instead LC_COLLATE in mkbuiltins

[Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>]

Fredrik Fornwall <fredrik@xxxxxxxxxxxx> wrote:
> In mkbuiltins LC_COLLATE is set, but since "The value of the LC_ALL
> environment variable has precedence over any of the other environment
> variables starting with LC_"
> (http://pubs.opengroup.org/onlinepubs/7908799/xbd/envvar.html), this
> has no effect when LC_ALL is set.
> 
> This breaks when having e.g. LC_ALL=en_US.UTF-8 during make, which
> causes the test case
>    dash -c :
> to fail, probably due to broken ordering in builtins.c. The patch
> corrects that by setting LC_ALL instead of LC_COLLATE.

This causes any errors printed by sort to come out in English.

Please fix this by simply setting LC_ALL to empty alongside
LC_COLLATE=C.

Thanks,
-- 
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe dash" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html