Re: [PATCH 5/4] [EVAL] Remove unused EV_BACKCMD flag

[Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxxx>]

On Sun, Apr 10, 2011 at 07:38:37AM +0000, Jonathan Nieder wrote:
> The original ash defered forking commands in backquotes so builtins
> could be run in the same context as the shell.  This behavior was
> controlled using the EV_BACKCMD to evaltree.
> 
> Unfortunately, as Matthias Scheler noticed in 1999 (NetBSD PR/7814),
> the result was counterintuitive; for example, echo "`cd /`" would
> change the cwd.  So ash 0.3.5 left out that optimization.  The
> EV_BACKCMD codepath stayed around, unused.
> 
> Some time between ash 0.3.5-11 and ash 0.3.8-37, Debian ash omitted
> the EV_BACKCMD pathway by guarding it with #ifdef notyet.  In dash
> 0.5.1 and later, the commented code is no more.  Let's finish the job
> and remove the last vestiges.  If someone wants to work on omitting
> the fork in backcmd, the remaining hints are not going to be very
> helpful, anyway.
> 
> Signed-off-by: Jonathan Nieder <jrnieder@xxxxxxxxx>

Patch applied.  Thanks a lot!
-- 
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe dash" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html