Re: [PATCH/RFC dash 0/4] Avoid a fork before running last command given to -c

[Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxxx>]

On Sun, Apr 10, 2011 at 07:18:17AM +0000, Jonathan Nieder wrote:
> Hi,
> 
> Jilles Tjoelker wrote[0]:
> 
> > Regarding sh -c optimization, I am in favour of this. Uselessly waiting
> > 'sh -c' processes annoy me. I made the change for FreeBSD 8.0 sh, which
> > is very similar to dash. The SVN changeset is r194128.
> 
> So I grabbed that changeset with
> 
> 	svn log -v svn://svn.freebsd.org/base/head/bin/sh -r 194128
> 	svn diff -r 194127:194128 svn://svn.freebsd.org/base/head/bin/sh
> 
> and made it a tiny bit smaller.   Here's the result.
> 
>    text    data     bss     dec     hex filename
>   83994    1784   11128   96906   17a8a dash.before-O2
>   83994    1784   11128   96906   17a8a dash.before-Os
>   84146    1784   11128   97058   17b22 dash.after-O2
>   84146    1784   11128   97058   17b22 dash.after-Os
> 
> On this amd64 the cost is 152 bytes of text.  Thoughts?

I must say that I don't see much value in this feature.  Adding
exec to the invocation is trivial.

Having said that, I will review the patches to see if they make
sense individually.

Thanks,
-- 
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe dash" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html