Re: [PATCH] [PARSER] Remove backslash before } in double-quotes in variable

[Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxxx>]

On Sun, Nov 21, 2010 at 02:42:22PM +0100, Jilles Tjoelker wrote:
> The backslash prevents the closing brace from terminating the
> substitution, therefore it should be removed.
> 
> FreeBSD sh test expansion/plus-minus2.0 starts working, no other tests
> are affected.
> 
> Example:
>   printf "%s\n" ${$+\}} ${$+"\}"} "${$+\}}"
> should print } three times, without backslashes.

I agree with respect to the last one, but not the middle one.

${$+"\}"} should be identical in behaviour to "\}", which with
all shells I have access to produces a brace with a backslash.

So please update your patch so that we do not regress on the
second one.

Thanks,
-- 
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe dash" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html