On 29 January 2015 at 22:13, Mason <mpeg.blue@xxxxxxx> wrote: > OK, so this is my TAKE 2 on the cpufreq driver, trying to remove > some dependencies on machine-specific definitions by getting the > virtual address at init via ioremap. (Is -EFAULT the right error > to return if ioremap fails?) > > I'm not sure where machine-specific information is supposed to > be stored though? Such as register definitions, or the physical > addresses/offsets. What if they need to be shared among several > source files? I can't just duplicate them... (I've tentatively > called it temp.h for the time being.) What do you want to do with this driver? If you want to get it reviewed, please send it properly with git-send-email instead of attachments.. If its just an internal one, then sorry, the lists aren't for such reviews. -- viresh -- To unsubscribe from this list: send the line "unsubscribe cpufreq" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html