Re: [PATCH 1/2] longhaul: Mark it as dangerous in Kconfig

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


W dniu 09.06.2014 01:02, Dave Jones pisze:
On Mon, Jun 09, 2014 at 12:20:42AM +0100, Ben Hutchings wrote:
  > longhaul quickly caused hard lockups and possibly killed the memory
  > module on my EPIA-PD board.  It is commented as:
  > 'BIG FAT DISCLAIMER: Work in progress code. Possibly *dangerous*'

that last part may have been overly dramatic. When I was originally
writing this driver I was using pre-production cpu's which were
marginal to begin with. Production hw should have been more tolerant.
What didn't help was a lot of the EPIAs were made with *Really*
shitty capacitors that would pop open and ooze over the boards. Might want
to eyeball those, you can usually tell when they've gone bad.

  > Let's put another warning where people are more likely to see it.

That said, I'm not against itbeing marked BROKEN (I thought it
already was), and certainly don't recommend distros enabling it.

I'd also not stand in the way of someone throwing it out completely
given the small amount of systems out there likely still running this.


If I may I would like to agree with Dave Jones. There is no point
in changing text which nobody will see in their logs. If somebody
wants to use the driver it is very easy now to compile module outside
the kernel tree. I didn't expected possibility of hardware damage
because driver just puts CPU to sleep to change frequency, but
VIA products have been full of bugs so looks like anything is
possible. Another matter is we have got these "dynamic ticks" in kernel
now and code in driver expects monotonic ticks and abuses them a bit
in order to be able to wake CPU from sleep. Does it make it obsolete?

Rafał Bilski

To unsubscribe from this list: send the line "unsubscribe cpufreq" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at

[Index of Archives]     [Linux Kernel Devel]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Forum]     [Linux SCSI]

  Powered by Linux