Re: Another powernow-k6 bug

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 2014-04-21 at 11:03 +0530, Viresh Kumar wrote:
> On Thu, Apr 17, 2014 at 12:53 AM, Ben Hutchings <ben@xxxxxxxxxxxxxxx> wrote:
> > While looking at your recent powernow-k6 fixes (thanks for those), I
> > noticed that powernow_k6_cpu_exit() doesn't work properly:
> >
> > static int powernow_k6_cpu_exit(struct cpufreq_policy *policy)
> > {
> >         unsigned int i;
> >         for (i = 0; i < 8; i++) {
> >                 if (i == max_multiplier)
> >                         powernow_k6_set_state(i);
> >         }
> 
> Yeah, there is a issue there. But why do we need to set freq to
> highest freq on exit()? Probably this code can be simply removed?
[...]

Because that is how the CPU was running before the driver was loaded.

Ben.

-- 
Ben Hutchings
Knowledge is power.  France is bacon.

Attachment: signature.asc
Description: This is a digitally signed message part


[Index of Archives]     [Linux Kernel Devel]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Forum]     [Linux SCSI]

  Powered by Linux