On Thu, Apr 17, 2014 at 12:53 AM, Ben Hutchings <ben@xxxxxxxxxxxxxxx> wrote:
> While looking at your recent powernow-k6 fixes (thanks for those), I
> noticed that powernow_k6_cpu_exit() doesn't work properly:
>
> static int powernow_k6_cpu_exit(struct cpufreq_policy *policy)
> {
> unsigned int i;
> for (i = 0; i < 8; i++) {
> if (i == max_multiplier)
> powernow_k6_set_state(i);
> }
Yeah, there is a issue there. But why do we need to set freq to
highest freq on exit()? Probably this code can be simply removed?
> cpufreq_frequency_table_put_attr(policy->cpu);
This doesn't exist anymore in latest sources.
> return 0;
> }
>
> As max_multiplier is the actual multiplier * 10, this will never change
> the state. I'm guessing this should be something like:
>
> for (i = 0; (clock_ratio[i].frequency != CPUFREQ_TABLE_END); i++)
> if (clock_ratio[i].driver_data == max_multiplier)
--
viresh
--
To unsubscribe from this list: send the line "unsubscribe cpufreq" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
