On 14-01-09 10:17 AM, Viresh Kumar wrote: > On Thu, Jan 9, 2014 at 8:40 PM, Paul Gortmaker > <paul.gortmaker@xxxxxxxxxxxxx> wrote: >> None of these files are actually using any __init type directives >> and hence don't need to include <linux/init.h>. Most are just a >> left over from __devinit and __cpuinit removal, or simply due to >> code getting copied from one driver to the next. > > Are you sure? Its not only about devinit or cpuinit but module_init() > and others as well. And they are pretty much used by most of them. Actually, module_init is an interesting point; we are implicitly getting init.h in module.h -- but (1) that should be explicit, and (2) module_init should/could really be in module.h and not stuck in init.h I'll add that to my queue and do some testing. Thanks for the comments, Paul. -- To unsubscribe from this list: send the line "unsubscribe cpufreq" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html