Re: [PATCH] drivers/cpufreq: delete non-required instances of include <linux/init.h>

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jan 9, 2014 at 8:56 PM, Paul Gortmaker
<paul.gortmaker@xxxxxxxxxxxxx> wrote:
> Yes I am sure.  I start with this:
>
> -------------
> #!/bin/bash
>
> if [ "$1" = "" ]; then
>         echo must supply path name
>         exit 1
> fi
>
> for i in `git grep -l linux/init.h $1` ; do
>         grep -q '__ref\|__init\|__cpuinit\|__meminit\|__MEMINIT\|__CPUINIT\|__INIT\|__REF\|__HEAD' $i

You missed all initcalls here.

>         if [ $? != 0 ] ; then
>                 echo $i
>                 sed -i '/linux\/init.h/d' $i
>         fi
> done
> --------------
>
> which as you can see whitelists any real users, and then I
> follow up with build testing to double check.

That might have passed because init.h is still included indirectly.

These are the usages which I can see easily, there might be
others too..

 drivers/cpufreq/powernow-k8.c: late_initcall and module_exit
 drivers/cpufreq/s3c2412-cpufreq.c: arch_initcall
 drivers/cpufreq/s3c2440-cpufreq.c: subsys_initcall
 drivers/cpufreq/spear-cpufreq.c: late_initcall

> I will note that
> in this particular case, I couldn't find an ARM defconfig that
> actually enabled any CONFIG_ARM_S3C24xx options though.

Haven't looked into this for now :(
--
To unsubscribe from this list: send the line "unsubscribe cpufreq" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel Devel]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Forum]     [Linux SCSI]

  Powered by Linux