Re: [PATCH V2 Resend 43/92] cpufreq: cris: don't initialize part of policy that is set by core too

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Oct 03, 2013 at 04:58:37PM +0200, Viresh Kumar wrote:
> Many common initializations of struct policy are moved to core now and hence
> this driver doesn't need to do it. This patch removes such code.
> 
> Most recent of those changes is to call ->get() in the core after calling
> ->init().

You should already have gotten my Acked-by: for this series, but here it is again:

Acked-by: Jesper Nilsson <jesper.nilsson@xxxxxxxx>

> Cc: Mikael Starvik <starvik@xxxxxxxx>
> Cc: linux-cris-kernel@xxxxxxxx
> Signed-off-by: Viresh Kumar <viresh.kumar@xxxxxxxxxx>
> ---
>  drivers/cpufreq/cris-artpec3-cpufreq.c | 1 -
>  drivers/cpufreq/cris-etraxfs-cpufreq.c | 1 -
>  2 files changed, 2 deletions(-)
> 
> diff --git a/drivers/cpufreq/cris-artpec3-cpufreq.c b/drivers/cpufreq/cris-artpec3-cpufreq.c
> index d26f4e4..4d88e4f 100644
> --- a/drivers/cpufreq/cris-artpec3-cpufreq.c
> +++ b/drivers/cpufreq/cris-artpec3-cpufreq.c
> @@ -73,7 +73,6 @@ static int cris_freq_cpu_init(struct cpufreq_policy *policy)
>  {
>  	/* cpuinfo and default policy values */
>  	policy->cpuinfo.transition_latency = 1000000; /* 1ms */
> -	policy->cur = cris_freq_get_cpu_frequency(0);
>  
>  	return cpufreq_table_validate_and_show(policy, cris_freq_table);
>  }
> diff --git a/drivers/cpufreq/cris-etraxfs-cpufreq.c b/drivers/cpufreq/cris-etraxfs-cpufreq.c
> index d384e63..f7d2d49 100644
> --- a/drivers/cpufreq/cris-etraxfs-cpufreq.c
> +++ b/drivers/cpufreq/cris-etraxfs-cpufreq.c
> @@ -72,7 +72,6 @@ static int cris_freq_cpu_init(struct cpufreq_policy *policy)
>  {
>  	/* cpuinfo and default policy values */
>  	policy->cpuinfo.transition_latency = 1000000;	/* 1ms */
> -	policy->cur = cris_freq_get_cpu_frequency(0);
>  
>  	return cpufreq_table_validate_and_show(policy, cris_freq_table);
>  }
> -- 
> 1.7.12.rc2.18.g61b472e

/^JN - Jesper Nilsson
-- 
               Jesper Nilsson -- jesper.nilsson@xxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe cpufreq" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel Devel]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Forum]     [Linux SCSI]

  Powered by Linux