On Thu, Oct 03, 2013 at 04:58:01PM +0200, Viresh Kumar wrote:
> Most of the CPUFreq drivers do similar things in .exit() and .verify() routines
> and .attr. So its better if we have generic routines for them which can be used
> by cpufreq drivers then.
>
> This patch uses these generic routines for this driver.
You should already have gotten my Acked-by: for this series, but here it is again:
Acked-by: Jesper Nilsson <jesper.nilsson@xxxxxxxx>
> Cc: Mikael Starvik <starvik@xxxxxxxx>
> Cc: linux-cris-kernel@xxxxxxxx
> Signed-off-by: Viresh Kumar <viresh.kumar@xxxxxxxxxx>
> ---
> drivers/cpufreq/cris-artpec3-cpufreq.c | 23 +++--------------------
> drivers/cpufreq/cris-etraxfs-cpufreq.c | 22 +++-------------------
> 2 files changed, 6 insertions(+), 39 deletions(-)
>
> diff --git a/drivers/cpufreq/cris-artpec3-cpufreq.c b/drivers/cpufreq/cris-artpec3-cpufreq.c
> index 444fd96..d26f4e4 100644
> --- a/drivers/cpufreq/cris-artpec3-cpufreq.c
> +++ b/drivers/cpufreq/cris-artpec3-cpufreq.c
> @@ -54,11 +54,6 @@ static void cris_freq_set_cpu_state(struct cpufreq_policy *policy,
> cpufreq_notify_transition(policy, &freqs, CPUFREQ_POSTCHANGE);
> };
>
> -static int cris_freq_verify(struct cpufreq_policy *policy)
> -{
> - return cpufreq_frequency_table_verify(policy, &cris_freq_table[0]);
> -}
> -
> static int cris_freq_target(struct cpufreq_policy *policy,
> unsigned int target_freq,
> unsigned int relation)
> @@ -84,26 +79,14 @@ static int cris_freq_cpu_init(struct cpufreq_policy *policy)
> }
>
>
> -static int cris_freq_cpu_exit(struct cpufreq_policy *policy)
> -{
> - cpufreq_frequency_table_put_attr(policy->cpu);
> - return 0;
> -}
> -
> -
> -static struct freq_attr *cris_freq_attr[] = {
> - &cpufreq_freq_attr_scaling_available_freqs,
> - NULL,
> -};
> -
> static struct cpufreq_driver cris_freq_driver = {
> .get = cris_freq_get_cpu_frequency,
> - .verify = cris_freq_verify,
> + .verify = cpufreq_generic_frequency_table_verify,
> .target = cris_freq_target,
> .init = cris_freq_cpu_init,
> - .exit = cris_freq_cpu_exit,
> + .exit = cpufreq_generic_exit,
> .name = "cris_freq",
> - .attr = cris_freq_attr,
> + .attr = cpufreq_generic_attr,
> };
>
> static int __init cris_freq_init(void)
> diff --git a/drivers/cpufreq/cris-etraxfs-cpufreq.c b/drivers/cpufreq/cris-etraxfs-cpufreq.c
> index 428395e..d384e63 100644
> --- a/drivers/cpufreq/cris-etraxfs-cpufreq.c
> +++ b/drivers/cpufreq/cris-etraxfs-cpufreq.c
> @@ -54,11 +54,6 @@ static void cris_freq_set_cpu_state(struct cpufreq_policy *policy,
> cpufreq_notify_transition(policy, &freqs, CPUFREQ_POSTCHANGE);
> };
>
> -static int cris_freq_verify(struct cpufreq_policy *policy)
> -{
> - return cpufreq_frequency_table_verify(policy, &cris_freq_table[0]);
> -}
> -
> static int cris_freq_target(struct cpufreq_policy *policy,
> unsigned int target_freq, unsigned int relation)
> {
> @@ -82,25 +77,14 @@ static int cris_freq_cpu_init(struct cpufreq_policy *policy)
> return cpufreq_table_validate_and_show(policy, cris_freq_table);
> }
>
> -static int cris_freq_cpu_exit(struct cpufreq_policy *policy)
> -{
> - cpufreq_frequency_table_put_attr(policy->cpu);
> - return 0;
> -}
> -
> -static struct freq_attr *cris_freq_attr[] = {
> - &cpufreq_freq_attr_scaling_available_freqs,
> - NULL,
> -};
> -
> static struct cpufreq_driver cris_freq_driver = {
> .get = cris_freq_get_cpu_frequency,
> - .verify = cris_freq_verify,
> + .verify = cpufreq_generic_frequency_table_verify,
> .target = cris_freq_target,
> .init = cris_freq_cpu_init,
> - .exit = cris_freq_cpu_exit,
> + .exit = cpufreq_generic_exit,
> .name = "cris_freq",
> - .attr = cris_freq_attr,
> + .attr = cpufreq_generic_attr,
> };
>
> static int __init cris_freq_init(void)
> --
> 1.7.12.rc2.18.g61b472e
/^JN - Jesper Nilsson
--
Jesper Nilsson -- jesper.nilsson@xxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe cpufreq" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
