On Wed, 17 Jul 2013 13:22:20 +0530 Viresh Kumar viresh.kumar@xxxxxxxxxx wrote, > On 17 July 2013 12:47, Lukasz Majewski <l.majewski@xxxxxxxxxxx> wrote: > > On Wed, 17 Jul 2013 10:54:55 +0530 Viresh Kumar > > viresh.kumar@xxxxxxxxxx wrote, > >> On 16 July 2013 17:20, Lukasz Majewski <l.majewski@xxxxxxxxxxx> > >> wrote: > >> > On Tue, 16 Jul 2013 15:28:40 +0530 Viresh Kumar > >> > viresh.kumar@xxxxxxxxxx wrote, > >> >> On 4 July 2013 14:20, Lukasz Majewski <l.majewski@xxxxxxxxxxx> > >> >> wrote: > >> >> > diff --git a/drivers/cpufreq/Kconfig b/drivers/cpufreq/Kconfig > >> >> > >> >> > +config CPU_FREQ_BOOST_SW > >> >> > + bool "CPU frequency overclocking (BOOST)" > >> >> > >> >> Name it "CPU Frequency Overclocking - Software" > >> > > >> > Thanks, I had a puzzle to came up with a good short name :-). > >> > > >> >> > >> >> > + depends on ARM_EXYNOS_CPUFREQ && EXYNOS_THERMAL > >> > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [*] > >> >> > >> >> Remote Exynos from here. If you want to enable it for your > >> >> platform by default, then select it from EXYNOS. > > > > I can change ARM_EXYNOS_CPUFREQ -> CPUFREQ at [*] > > We are in cpufreq Kconfig and so dependency is automatically > there on cpufreq. So then, it can be removed. > > >> > >> I misread it a bit. I wanted to say make it dependent only on > >> THERMAL and not on Exynos. > > > > The cpufreq boost feature is possible to be enabled only when those > > [*] dependencies are met. Moreover, it is disabled by default. > > > > This means that not only THERMAL generic code must be supported, but > > also EXYNOS specific one - like per SoC trip points [**]. > > > > With thermal it is possible (and correct) to only define THERMAL, > > with no platform (in this case Exynos) specific definitions. To > > force potential user to define [**], I think, that EXYNOS_THERMAL > > is required. > > > >> > >> > The purpose of the condition [*] here is to prevent from enabling > >> > boost when thermal for Exynos is not supported. > >> > >> Why? Can't others use it? Its not exynos specific :) > > > > No it is not exynos specific. > > For other platform one need to define: > > > > depends on CPUFREQ && (EXYNOS_THERMAL || > > <PLATFORM_SUPPORTED>_THERMAL) > > Exactly. I don't want this kind of mess to be present here. > > People selecting this feature must know what it does and > dependency on a coolant is enough. > > For other drivers, selecting this doesn't matter as they don't > support boost. Then it should be enough to only write: depends on THERMAL (since CPUFREQ is already enabled for entering this menu). -- Best regards, Lukasz Majewski Samsung R&D Institute Poland (SRPOL) | Linux Platform Group -- To unsubscribe from this list: send the line "unsubscribe cpufreq" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
